Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorpio: some improvement required #682

Open
3 of 6 tasks
yyk808 opened this issue Nov 12, 2024 · 3 comments
Open
3 of 6 tasks

Scorpio: some improvement required #682

yyk808 opened this issue Nov 12, 2024 · 3 comments

Comments

@yyk808
Copy link
Contributor

yyk808 commented Nov 12, 2024

In the past few days I tested scorpio for integrating zed with mega and here are my suggestions for it.

  • Gracefully start and quit: When scorpio receives a signal to quit, it won't umount the mountpoint. Causing it cannot correctly start in the next time.

  • Confusing meanings for mount: mountpoint and mount doesn't share the same meaning

    let mountpoint =OsStr::new("/home/luxian/dic") ;

    .route("/api/fs/mount", post(mount_handler))

  • mountpoint should not be hard-coded: request it from /api/config would be nice.

  • Duplicated mount paths: Simply call /api/mount on the same path twice and you'll got:
    {7B6BC589-F056-4707-92A2-B5EAE032039E}

  • Let's use absolute path: Just a suggestion.

  • IO Error on reading non-exist files: Using cat command for a non-exsiting file in the fuse would get a IO Error message.
    {3229F94F-EE80-469D-9610-EC5530707324}

@yyk808
Copy link
Contributor Author

yyk808 commented Nov 12, 2024

@Ivanbeethoven

@Ivanbeethoven
Copy link
Contributor

Got it !

Ivanbeethoven added a commit to Ivanbeethoven/mega that referenced this issue Nov 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
[scorpio]: Optimize user experience, associated with issue #682.
@Ivanbeethoven
Copy link
Contributor

Ivanbeethoven commented Nov 15, 2024

PRs #688 and #687 has solved the problems :

  • Gracefully start and quit
  • Confusing meanings for mount
  • mountpoint should not be hard-coded
  • Duplicated mount paths: Now you can't mount twice

TODO:

  • IO Error on reading non-exist files : need some error check with libc function .
  • Let's use absolute path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants