Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-tfdata integration (tests) #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

knopt
Copy link

@knopt knopt commented Apr 28, 2020

There where 4 problems:

  • go-tfdata is private
  • go-tfdata is on gitlab-master.nvidia.com, not github.com/NVIDIA/go-tfdata
  • go-tfdata is on gitlab-master.nvidia.com, but declares itself as github.com/NVIDIA/go-tfdata
  • go mod tidy doesn't look at build dependencies

See README.md for steps on how to make it work.

Additionally, integration could be slightly easier if we decided on a common interface/type of Sample. I believe Bytes is not the best choice from go-tfdata perspective

@knopt
Copy link
Author

knopt commented Apr 29, 2020

git config --global url."ssh://[email protected]:12051/".insteadOf "https://github.com/NVIDIA/go-tfdata"

might be even better, and then no replace in go.mod. I'll try to change it.

@knopt knopt force-pushed the go-tfdata branch 2 times, most recently from 5a26737 to b4c0f7e Compare April 30, 2020 13:25
@knopt knopt force-pushed the go-tfdata branch 2 times, most recently from fde2e02 to 93b3850 Compare May 11, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants