From cbbc6f1f0b87a2285a3d5a932b3f1560dffd9b26 Mon Sep 17 00:00:00 2001 From: Shreyas Sharma <72344404+Shreyas281299@users.noreply.github.com> Date: Mon, 15 Apr 2024 21:28:10 +0530 Subject: [PATCH] fix(internal-plugin-mercury): use-mocha-for-uts (#3535) Co-authored-by: Shreyas Sharma --- .../@webex/internal-plugin-mercury/package.json | 2 +- .../test/unit/spec/mercury-events.js | 2 +- .../test/unit/spec/mercury.js | 6 +++--- .../test/unit/spec/socket.js | 14 ++++++++------ 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/@webex/internal-plugin-mercury/package.json b/packages/@webex/internal-plugin-mercury/package.json index 93d5f4a4f1a..ecec64428a6 100644 --- a/packages/@webex/internal-plugin-mercury/package.json +++ b/packages/@webex/internal-plugin-mercury/package.json @@ -62,6 +62,6 @@ "test": "yarn test:style && yarn test:unit && yarn test:integration && yarn test:browser", "test:browser": "webex-legacy-tools test --integration --unit --runner karma", "test:style": "eslint ./src/**/*.*", - "test:unit": "webex-legacy-tools test --unit --runner jest" + "test:unit": "webex-legacy-tools test --unit --runner mocha" } } diff --git a/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury-events.js b/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury-events.js index 58040bd99bb..599d61e19a6 100644 --- a/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury-events.js +++ b/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury-events.js @@ -142,7 +142,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('when `mercury.buffer_state` is received', () => { + describe('when `mercury.buffer_state` is received', () => { // This test is here because the buffer states message may arrive before // the mercury Promise resolves. it('gets emitted', (done) => { diff --git a/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury.js b/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury.js index 8a8378f9ea7..397a44d530f 100644 --- a/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury.js +++ b/packages/@webex/internal-plugin-mercury/test/unit/spec/mercury.js @@ -381,7 +381,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('when webSocketUrl is provided', () => { + describe('when webSocketUrl is provided', () => { it('connects to Mercury with provided url', () => { const webSocketUrl = 'ws://providedurl.com'; const promise = mercury.connect(webSocketUrl); @@ -403,7 +403,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('Websocket proxy agent', () => { + describe('Websocket proxy agent', () => { afterEach(() => { delete webex.config.defaultMercuryOptions; }); @@ -451,7 +451,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('#disconnect()', () => { + describe('#disconnect()', () => { it('disconnects the WebSocket', () => mercury .connect() diff --git a/packages/@webex/internal-plugin-mercury/test/unit/spec/socket.js b/packages/@webex/internal-plugin-mercury/test/unit/spec/socket.js index 8224963ea2e..b34f09bdc82 100644 --- a/packages/@webex/internal-plugin-mercury/test/unit/spec/socket.js +++ b/packages/@webex/internal-plugin-mercury/test/unit/spec/socket.js @@ -40,8 +40,10 @@ describe('plugin-mercury', () => { }); beforeEach(() => { - sinon.stub(Socket, 'getWebSocketConstructor').callsFake(() => function (...args) { - mockWebSocket = new MockWebSocket(...args); + sinon.stub(Socket, 'getWebSocketConstructor').callsFake( + () => + function (...args) { + mockWebSocket = new MockWebSocket(...args); return mockWebSocket; } @@ -69,7 +71,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('#open()', () => { + describe('#open()', () => { let socket; beforeEach(() => { @@ -213,7 +215,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('#open()', () => { + describe('#open()', () => { it('requires a url parameter', () => { const s = new Socket(); @@ -566,7 +568,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('#onclose()', () => { + describe('#onclose()', () => { it('stops further ping checks', () => { socket._ping.resetHistory(); assert.notCalled(socket._ping); @@ -750,7 +752,7 @@ describe('plugin-mercury', () => { }); }); - describe.skip('#_ping()', () => { + describe('#_ping()', () => { let id; beforeEach(() => {