From 4f6a8dbb92b7d71e4c50ab708dfb5265205dfb38 Mon Sep 17 00:00:00 2001 From: CastagnaIT Date: Mon, 2 Sep 2024 11:40:35 +0200 Subject: [PATCH 1/2] [GUITextLayout] Removed custom chinese chars line break --- xbmc/guilib/GUITextLayout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xbmc/guilib/GUITextLayout.h b/xbmc/guilib/GUITextLayout.h index 1b01d1db8bf70..a357db0573bf7 100644 --- a/xbmc/guilib/GUITextLayout.h +++ b/xbmc/guilib/GUITextLayout.h @@ -187,7 +187,7 @@ class CGUITextLayout inline bool CanWrapAtLetter(character_t letter) const XBMC_FORCE_INLINE { character_t ch = letter & 0xffff; - return ch == L' ' || (ch >=0x4e00 && ch <= 0x9fff); + return ch == L' '; }; static void AppendToUTF32(const std::string &utf8, character_t colStyle, vecText &utf32); static void AppendToUTF32(const std::wstring &utf16, character_t colStyle, vecText &utf32); From 79215959fe26d9544ee9ba611a8671bb374e09af Mon Sep 17 00:00:00 2001 From: CastagnaIT Date: Tue, 3 Sep 2024 09:00:01 +0200 Subject: [PATCH 2/2] [GUITextLayout] Add todo comment for unicode spaces --- xbmc/guilib/GUITextLayout.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xbmc/guilib/GUITextLayout.h b/xbmc/guilib/GUITextLayout.h index a357db0573bf7..7634d6eb14b09 100644 --- a/xbmc/guilib/GUITextLayout.h +++ b/xbmc/guilib/GUITextLayout.h @@ -187,6 +187,7 @@ class CGUITextLayout inline bool CanWrapAtLetter(character_t letter) const XBMC_FORCE_INLINE { character_t ch = letter & 0xffff; + //! @todo: unicode spaces are not handled, to check also all other GUI parts return ch == L' '; }; static void AppendToUTF32(const std::string &utf8, character_t colStyle, vecText &utf32);