Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection editing revamp #2328

Open
emma-sg opened this issue Jan 21, 2025 · 0 comments · May be fixed by #2332
Open

Collection editing revamp #2328

emma-sg opened this issue Jan 21, 2025 · 0 comments · May be fixed by #2332
Assignees

Comments

@emma-sg
Copy link
Member

emma-sg commented Jan 21, 2025

Note

This issue originally was about combining all (or at least most — details below!) collection editing controls into one unified collection editing dialog. Since then, we've figured out that there'd be some issues with that approach, so this issue is now tracking updates to the collection editing experience intended to address the same underlying issues in different ways.

Underlying problems with the current editing experience

  • In the collection detail page, editable properties are spread out across a bunch of different dialogs with unclear names & accessed from inconsistent places
    • This is especially an issue with name, summary, and description, and thumbnail and starting view
  • There's no way to edit the thumbnail except via the sharing dialog, which isn't obvious
  • There's no way to set the thumbnail to a page thumbnail except via the replay config dialog, which also isn't obvious
  • The dialog to edit name and summary is called "metadata", which isn't necessarily intuitive for users not coming from the world of libraries and archiving
  • Collection details (such as name, summary, thumbnail, and sharing settings) can't be edited from the public collections list on the org dashboard, which makes editing these public-facing attributes a pain because a user needs to click through to the detail page for each collection, then through multiple dialogs from multiple places to update these attributes, which breaks context
  • Controls and actions aren't placed consistently between the public and private collection detail pages, which can be confusing when editing attributes that users expect to find in similar/analogous places
  • Sharing controls in the collection list are cumbersome, they're stepped and so require opening the menu multiple times to move from private to unlisted to public

How we're addressing these issues

In the first pass of this issue, we'd attempted to merge all collection editing controls into a single dialog that could be accessed from the collection detail view, the collection list, and the public collection grid in the org dashboard. While this was mostly a nice experience, we moved away from this for a couple reasons.

The archived item list and associated archived item selection dialog were a notable exception to this first attempt at a unified dialog, because implementing this would have required either a secondary level of dialogs, so that we could also include the full archived item list in the editing dialog; or merging of this item selection dialog into the editing dialog, which would have been a confusing experience with a secondary level of change tracking and conflating tabs/filters in these different contexts. Unfortunately, the exclusion of the archived item list & selection ended up being confusing for users as well, as they expected to find these tools within the same dialog as all the other editing controls but couldn't. Additionally, the tabbed editing experience made unsaved changes difficult to track across tabs that weren't currently visible.

For these reasons, we decided to scale back these efforts to include only the more-or-less public-facing aspects of collections (i.e. name, summary, thumbnail, and sharing settings) in this new dialog that can be access from various parts of the app, and still require users to get to know the more complicated but more powerful collection detail view in order to edit the collection's content.

Other related changes we might try to accomplish in this task

  • Updating the "metadata" label to something less tied to specific meanings in an archiving context — "details" probably?
  • Moving share button/dropdown to icon buttons
  • Updating public collection & org dashboard headers to be more consistent with each other
  • Adding the ability to set the replay initial view to the currently displayed page in the replay (rather then requiring you to enter the url manually)

Related information

Original issue contents

Move all collection editing controls into a single unified "edit" view/dialog

  • move all collection editing things into one "edit" view - maybe a primary "edit" button that swaps view to tabbed view?
    • unsure if this is the best solution — maybe it can be integrated into the single view rather than being separate one?
    • edit view:
      • sharing settings
      • title, summary, description
      • configure replay view
      • maybe select items??
    • actions dropdown:
      • maybe edit collection
      • download
      • delete
    • icon buttons for sharing (one each! with tooltips)
      • copy link
      • view embed code
      • visit public page
  • in public collection page:
    • when logged in, "edit" button opens a modal with editing options, rather than taking you to logged-in collection page
  • "select items" should still be viewable/actionable, and not require clicking through a bunch of tabs

https://app.excalidraw.com/s/2YrNHjC4Nsy/A4FT0hXIxav

Some more TODOs:

  • Disable the homepage tab in non-detail-page contexts (with link to detail page & opened dialog there)
  • show notice on homepage tab when crawler versions don't match versions supporting page selection/thumbnails
    • @ikreymer which version range should be ok?
  • on detail page, make collection access icon into a "copy url" link when relevant
  • thumbnail selector should have labels
    • Image
  • ensure action menus are organized consistently in different views

Notes from my walkthrough/demo session with @missclaraitzel on 2025-01-17

  • org dashboard view
    • from org dashboard, menu should include metadata editing
    • visit public profile/copy link to profile should be full button
    • when org isn't public, it's not clear why public collections aren't showing up on org dashboard
    • should be able to edit, add description, rename, etc, from public collection list in org dashboard (three dot menu)
  • collection detail view - "configure replay view"
    • when there's only one page archived, initial view options should include that one page
    • when there's a single html page but a bunch of non-html pages, the html page should show up first when selecting initial page
    • can't select a root page - e.g. https://law.mit.edu/ vs https://law.mit.edu/pub/2020computationallawcourse, the latter can be selected when the former can't
    • lots of "couldn't load preview"
    • "200" isn't clear, should include checkmarks instead? or maybe "ok" — probably omit 200s
    • separation of title, summary, and description is not clear — they should all be editable
    • name and summary shouldn't be called "metadata"
  • collection detail view - "link settings"
    • thumbnail being here and not in metadata/about/etc is weird
  • collection list
    • "create share link" in collections list menu should be full sharing menu, not just "make collection unlisted"
      • just realized that this currently lets you move one visibility step at a time
    • sort by visibility
@emma-sg emma-sg self-assigned this Jan 21, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Jan 21, 2025
@Shrinks99 Shrinks99 moved this from Todo to Implementing in Webrecorder Projects Jan 21, 2025
@emma-sg emma-sg linked a pull request Jan 22, 2025 that will close this issue
12 tasks
@emma-sg emma-sg added this to the Public Collections milestone Jan 22, 2025
@emma-sg emma-sg changed the title Move all collection editing controls into a single unified "edit" view/dialog Collection editing revamp Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Implementing
Development

Successfully merging a pull request may close this issue.

1 participant