Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test trailing slash removal (will be closed as all work is on saas) #4329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Oct 21, 2024

Description

Do redirect on trailing slash

https://github.com/webstudio-is/webstudio-saas/pull/331

closes #4327

Steps for reproduction

Test following urls

https://slash-ubje8.wstd.work/test//// <-- Redirect
https://slash-ubje8.wstd.work/test/  <-- Redirect
https://slash-ubje8.wstd.work///  <-- Redirect
https://slash-ubje8.wstd.work  <-- Do nothing
https://slash-ubje8.wstd.work/  <-- Do nothing

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov changed the title Empty chore: Test trailing slash removal Oct 21, 2024
@istarkov istarkov changed the title chore: Test trailing slash removal chore: Test trailing slash removal (will be closed as all work is on saas) Oct 21, 2024
@istarkov istarkov marked this pull request as ready for review November 4, 2024 03:58
@istarkov istarkov requested a review from kof November 4, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure SEO tools don't complain about trailing slash
1 participant