Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider a sleepyhollow wrapper api layer #6

Open
weisjohn opened this issue Feb 18, 2015 · 0 comments
Open

consider a sleepyhollow wrapper api layer #6

weisjohn opened this issue Feb 18, 2015 · 0 comments

Comments

@weisjohn
Copy link
Owner

Frankly, the PhantomJS API is too hard. A high-level sleepyhollow API could exist which utilizes sleepyhollow-node/phantom as the bridge.

For example, render is not async, but it does block, but it does not block until the image is written to disk, rather it just blocks until some Qt abstraction flushes: ariya/phantomjs#11084 There's a work-around in ariya/phantomjs#11780 which demonstrates how they determine if the render really has completed. ( vvavrychuk/phantomjs@63955e3#diff-189aee7cd62ea62e8a4e9979ddbbe152R2030 ) This could simply be implemented in an abstraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant