Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round numbers to one decimal place #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdcemulator
Copy link

@pdcemulator pdcemulator commented Dec 27, 2022

Fix temperature values like 24.200000000000003

ElsterReadResponseFrame(timestamp=2022-12-26 22:50:37.520119, sender=180, receiver=680, elster_index=c0fc, value=00f8 (248), )
ElsterReadRequestFrame(timestamp=2022-12-26 22:50:38.015223, sender=680, receiver=180, elster_index=c102, )
[2022-12-26 22:50:38.024244] Register temp-vorlauf-ehs-ist-tvbh2: 24.200000000000003

Fix temperature values like 12.300000000001
@weltenwort
Copy link
Owner

Thanks for submitting this improvement! I wonder if the same rounding precision is appropriate for every sensor or if it should become a per-sensor configuration setting 🤔 any thoughts on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants