Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support payment from PDA accounts #18

Open
febo opened this issue Feb 16, 2024 · 2 comments
Open

Support payment from PDA accounts #18

febo opened this issue Feb 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@febo
Copy link

febo commented Feb 16, 2024

Currently, the royalty payment only support payer_address that is a wallet (SystemProgram owned accounts). There are scenarios where the funds are in escrow PDA accounts. Trying to make the payment from these accounts will failed since they are not owned by SystemProgram and therefore cannot be used in system_instruction::transfer.

https://github.com/wen-community/wen-new-standard/blob/7468d3fe711ba7b4aa9b4ea6f9c0f8bf0ad8211c/programs/wen-royalty-distribution/src/instructions/update.rs#L123

@balmy-gazebo
Copy link
Contributor

There's no clean way to do this without switching to SPL transfers only. Open to ideas. Alternatively, transferring funds from PDA to Signer earlier in the transaction may work.

@mons2024
Copy link

Yes

@kespinola kespinola added the bug Something isn't working label May 7, 2024
@kespinola kespinola moved this to Up Next in WEN Release Planning May 20, 2024
@kespinola kespinola moved this from Up Next to In Progress in WEN Release Planning May 20, 2024
@kespinola kespinola moved this from In Progress to Backlog in WEN Release Planning Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants