Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Distribution account in approve #49

Open
balmy-gazebo opened this issue Mar 19, 2024 · 1 comment
Open

Validate Distribution account in approve #49

balmy-gazebo opened this issue Mar 19, 2024 · 1 comment
Assignees
Labels
request for comment Seeking community feedback

Comments

@balmy-gazebo
Copy link
Contributor

Currently we are not validating the distribution account because this instruction in general is called assuming marketplaces properly account for royalties, however it is poor DX to allow ambiguous distribution accounts as uncaught errors will lead to loss of funds for creators if their distribution account were passed in incorrectly by a marketplace.

The hold up implementing this is that it would require passing in the group account to derive the Distribution PDA in approve. Once the Group Account is apart of the mint account we should be able to make this check. In the mean time potentially we should add a warning to the documentation.

@kespinola
Copy link
Contributor

Given that a marketplace can pass any amount to royalty distribution thus by passing it enforcement I strongly encourage dropping the protocol and instead provide interface for assisting in the paying out royalties consistently in all protocol utilizing WNS assets and leverage token extension guards to prevent bad actors.

@kespinola kespinola self-assigned this May 7, 2024
@kespinola kespinola added the request for comment Seeking community feedback label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request for comment Seeking community feedback
Projects
None yet
Development

No branches or pull requests

2 participants