Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived scripts for NParks report are deprecated #18

Open
kwekiii opened this issue Sep 4, 2021 · 3 comments
Open

Archived scripts for NParks report are deprecated #18

kwekiii opened this issue Sep 4, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@kwekiii
Copy link
Collaborator

kwekiii commented Sep 4, 2021

Just a note here that the scripts with _Nparks in the filename are actually no longer useable.

I tried to use them as a starting point for modification to incorporate switches for the extent of cropping of the full map, but ran into multiple errors when testing them, e.g., p_bz(), etc.

Probably no action needed at the moment, and still a good idea have them archived, but if we want to get them working again for re-running anything for NParks' purposes, would need some de-bugging.

@kwekiii kwekiii added the bug Something isn't working label Sep 4, 2021
@wengngai
Copy link
Owner

wengngai commented Sep 4, 2021

Found the issue and fixed it. the source lines need to source the corresponding "_Nparks" versions of the setup_map and functions R scripts. I couldn't test it because of an ongoing analysis but it should be working now

@kwekiii
Copy link
Collaborator Author

kwekiii commented Sep 9, 2021

I had already tried earlier with the _Nparks version of functions.R and I think also setup_map_three spp_Nparks.R but it doesn't work either.

@wengngai
Copy link
Owner

I've checked again and the _Nparks scripts should be fully functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants