Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between Eq. 15 and jtmpn.py:L81-L108? #19

Open
BarclayII opened this issue Sep 3, 2018 · 0 comments
Open

Inconsistency between Eq. 15 and jtmpn.py:L81-L108? #19

BarclayII opened this issue Sep 3, 2018 · 0 comments

Comments

@BarclayII
Copy link

BarclayII commented Sep 3, 2018

Consider three atoms A -- B -- C, where A and B are connected within the same clique C1, and B and C are connected but belonging to different cliques C1 and C2. The code in jtmpn.py:L81-L108 will assign a connection to B with a "dummy" edge corresponding to the tree message C2 -> C1. So
(1) The loopy BP on edge B -> A will also gather the tree message C2 -> C1, even if B and A are within the same clique.
(2) During readout phase, B will gather message not only from A -> B and C -> B, but also the tree message C2 -> C1.

Are these behaviors intended? I think they don't match Eq. 15 in the paper, where the message on an edge whose ends belong to the same clique does not gather any tree message, and the atoms does not gather tree messages during readout as well.

@BarclayII BarclayII changed the title Inconsistency between Eq. 15 and jtmpn.py:L81-L108 Inconsistency between Eq. 15 and jtmpn.py:L81-L108? Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant