Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller#set_tab instance method implemented but not documented #29

Open
jcamenisch opened this issue Jul 4, 2013 · 0 comments
Open

Comments

@jcamenisch
Copy link

I just spent a good bit of time writing ten different calls to set_tab :x, if: ->{ condition } in a controller, to set the current tab based on given params. I got it working perfectly, but hated the whole approach. It was begging to have set_tab called from a before_action filter instead of at the class level.

It finally dawned on me that that might be possible, even though the documentation says nothing about the capability. I checked the source, and there it is!

May I suggest mentioning this somewhere in the documentation? Would you consider a pull request if I worked on writing something up?

No promises, but I might be able to take some time to do that—if there's a chance it would be merged.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant