Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generate-at-breakpoints into functions to simplify it. #82

Open
AlecRaeside opened this issue Oct 9, 2014 · 5 comments
Open
Assignees

Comments

@AlecRaeside
Copy link
Contributor

The complexity of the generate-at-breakpoints mixin should be refactored by moving functionality into single purpose functions which should be unit testable.

@chris-pearce
Copy link
Contributor

Agree, ideas?.

And can you make sure to label it based on the relevant part of Scally? I've done this one.

@AlecRaeside
Copy link
Contributor Author

With moving logic into functions, do you think they should live the same file as the main mixin or in the functions folder? @chris-pearce

@chris-pearce
Copy link
Contributor

I think the same file as the mixin if they're only relevant to that mixin, if there's reuse elsewhere then move into the functions folder.

@chris-pearce
Copy link
Contributor

@AlecRaeside you still keen to do this?

@chris-pearce
Copy link
Contributor

@AlecRaeside you still think you'll do this? If not can you close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants