Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger images for ingredient details #724

Open
rolandgeider opened this issue Jan 18, 2025 · 10 comments
Open

Bigger images for ingredient details #724

rolandgeider opened this issue Jan 18, 2025 · 10 comments
Labels
good first issue Good for newcomers

Comments

@rolandgeider
Copy link
Member

E.g. when returning a found product from the scanner, we can just use the whole horizontal space

Image

@rolandgeider rolandgeider added the good first issue Good for newcomers label Jan 18, 2025
@Sangharshdeveloper
Copy link
Contributor

@rolandgeider Assign

@Dieterbe
Copy link
Contributor

Dieterbe commented Jan 18, 2025

IIRC I made the design deliberately like this. Didn't see value in making the image and the popup larger.

I suppose we could do what you suggest Roland if we keep the popup width and height the same, and if the ingredient image is in "landscape" orientation then we could use the width of the popup without affecting height.

@AbdelbassitAb
Copy link

Hello can i please take it , i want to contribute to this project

@rolandgeider
Copy link
Member Author

Yes, we definitely keep the pop-up size, just fill up the whole width. @Sangharshdeveloper can you take a look and post a screenshot? Then we can decide if it would be an improvement

@Sangharshdeveloper
Copy link
Contributor

Yes, I will do it

@Sangharshdeveloper
Copy link
Contributor

Image

@Sangharshdeveloper
Copy link
Contributor

Image

@Jackpkn
Copy link

Jackpkn commented Jan 19, 2025

@Sangharshdeveloper @rolandgeider
we canalso improve the alignment

@Dieterbe
Copy link
Contributor

@Sangharshdeveloper as i tried to explain before, making the image so big that we can't fit all information properly is not desirable.

@rolandgeider
Copy link
Member Author

yes, we should keep the height of the circle but use the whole width and just crop the rest (so the black square here)

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants