-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigger images for ingredient details #724
Comments
@rolandgeider Assign |
IIRC I made the design deliberately like this. Didn't see value in making the image and the popup larger. I suppose we could do what you suggest Roland if we keep the popup width and height the same, and if the ingredient image is in "landscape" orientation then we could use the width of the popup without affecting height. |
Hello can i please take it , i want to contribute to this project |
Yes, we definitely keep the pop-up size, just fill up the whole width. @Sangharshdeveloper can you take a look and post a screenshot? Then we can decide if it would be an improvement |
Yes, I will do it |
@Sangharshdeveloper @rolandgeider |
@Sangharshdeveloper as i tried to explain before, making the image so big that we can't fit all information properly is not desirable. |
E.g. when returning a found product from the scanner, we can just use the whole horizontal space
The text was updated successfully, but these errors were encountered: