Do not print error on jobstats issue #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log message at debug level when there is a jobstats collection issue, do not raise to console. Signed-off-by: Joe Grund <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 92.12% 91.77% -0.36%
==========================================
Files 41 41
Lines 5182 5201 +19
Branches 5182 5201 +19
==========================================
- Hits 4774 4773 -1
- Misses 372 391 +19
- Partials 36 37 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark for 5e1db10Click to view benchmark
|
RDruon
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Not working on my side.
Tried with
diff --git a/lustrefs-exporter/src/main.rs b/lustrefs-exporter/src/main.rs
index 8ef81e6..6749c35 100644
--- a/lustrefs-exporter/src/main.rs
+++ b/lustrefs-exporter/src/main.rs
@@ -18,7 +18,7 @@ use serde::Deserialize;
use std::{
borrow::Cow,
convert::Infallible,
- io::{self, BufReader},
+ io::{self, BufRead, BufReader},
net::SocketAddr,
};
use tokio::process::Command;
@@ -96,6 +96,7 @@ async fn scrape(Query(params): Query<Params>) -> Result<Response<Body>, Error> {
.arg("get_param")
.args(["obdfilter.*OST*.job_stats", "mdt.*.job_stats"])
.stdout(std::process::Stdio::piped())
+ .stderr(std::process::Stdio::piped())
.spawn()?;
Ok::<_, Error>(child)
@@ -112,6 +113,20 @@ async fn scrape(Query(params): Query<Params>) -> Result<Response<Body>, Error> {
))?,
);
+ let reader_stderr = BufReader::with_capacity(
+ 128 * 1_024,
+ child.stderr.take().ok_or(io::Error::new(
+ io::ErrorKind::NotFound,
+ "stderr missing for lctl jobstats call.",
+ ))?,
+ );
+
+ tokio::task::spawn(async move {
+ for line in reader_stderr.lines().map_while(Result::ok) {
+ tracing::debug!("stderr: {}", line);
+ }
+ });
+
let (_, rx) = lustrefs_exporter::jobstats::jobstats_stream(reader);
let stream = ReceiverStream::new(rx)But I am not getting any output. I guess because we are never awaiting it?
What output are you expecting that you are not getting? |
Benchmark for 485e366Click to view benchmark
|
RDruon
approved these changes
Aug 12, 2024
|
With latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log message at debug level when there is a jobstats collection issue, do not raise to console.