-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for child #75
Wait for child #75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 91.77% 91.66% -0.11%
==========================================
Files 41 41
Lines 5201 5207 +6
Branches 5201 5207 +6
==========================================
Hits 4773 4773
- Misses 391 397 +6
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark for 2eb784eClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to await both the response and the child at the same time.
Signed-off-by: Joe Grund <[email protected]>
Benchmark for 594e422Click to view benchmark
|
Wait for child to avoid process ID exhaust, see https://doc.rust-lang.org/std/process/struct.Child.html#warning