-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain stream instead of merge #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 91.68% 91.71% +0.03%
==========================================
Files 41 41
Lines 5207 5228 +21
Branches 5207 5228 +21
==========================================
+ Hits 4774 4795 +21
Misses 397 397
Partials 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Benchmark for c1e8a73Click to view benchmark
|
Benchmark for 113bc57Click to view benchmark
|
Benchmark for 7b4e669Click to view benchmark
|
breuhan
reviewed
Aug 20, 2024
breuhan
previously approved these changes
Aug 20, 2024
RDruon
changed the title
Add a newline to avoid printing jobstats at same level as previous stats
Chain stream instead of merge
Aug 20, 2024
Benchmark for ac5764fClick to view benchmark
|
jgrund
reviewed
Aug 20, 2024
breuhan
approved these changes
Aug 21, 2024
jgrund
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain stream instead of merging them.
Merge will interleave stream, that's not something we want since it will break prometheus format. See merge documentation at https://docs.rs/tokio-stream/latest/tokio_stream/trait.StreamExt.html#method.merge
Also add a newline to make sure we are printing stats with a separating empty line
From (mind the
{operation="open",component="mdt",target="es01a-MDT0000",jobid="node_exporter:989:es-2-virt3-co"}
):To:
I haven't been able to reproduce it as part of unit test