-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce the hierarchy restrictions #140
Comments
These manual tests are checking against hierarchy restrictions:
|
Adding back the hierachy restrictions for this event targetting is unforunate. We are forcing users into a model of how to design their application that the content must be present in the child of the current fullscreen element.Think of a series of divs that are all siblings and you click 'next'. Which would change the fullscreen element to the next element. In order to replicate that you'd need to do a bunch of tree modifications. Also it prevents you from re-entering a fullscreen element already on the stack. @domenic Adding Domenic in case he has any ideas here. |
(For my own note: there was a Gecko bug we can reuse if we end up not reverting the change.) |
That is not a usecase that the current Fullscreen API is supposed to support. You would end up having lots of elements in the fullscreen layer, and you cannot exit fullscreen in one statement (unless we add #70). If we want to serve this usecase, we may want an API like |
Also, if we are re-introducing the hierarchy restriction, we may need to revisit bug 27865 and see how modal dialog would need to interact with fullscreen... |
The hierarchy restrictions were removed in 766dc87 and 9592913 because it seemed to be unnecessary after we moved to the top layer model.
However, it forms an unfortunate combination with the change to make
fullscreenchange
event dispatched to element, that if we have multiple leaf fullscreen element in the stack, some of the element wouldn't get thefullscreenchange
event. I raised in #89 (comment), and @foolip said he's fine adding back these restrictions in #89 (comment) and opened #91 to do so.Recently, #91 was abandoned probably because of lack of activity and people don't recall the reasoning to do so. So I'm opening this issue to track that.
Blink currently doesn't have the hierarchy restrictions, while Gecko still has. And if we decide to re-introduce it, Blink may want to change before it's too late.
cc @dtapuska
The text was updated successfully, but these errors were encountered: