-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in Expo standalone #4
Comments
The plugin seems to get some values (like the final bundle path) from I suggest for @whoami-shubham to add all the options the plugin takes from argv as runOptions and if they're not present, use argv. I might make a pull request to implement this if I have the time. |
@AnzeBlaBla Thanks for the suggestion, a PR would be appreciated, I don't use expo, so I might not be able to recreate and test the fix for this issue. |
We decided not to implement obfuscation yet, but when we do, I'll make a PR to be able to use this plugin |
It worked for me on a managed expo app using a custom dev-client when I built a stand alone app for IOS through eas build command. Confirmed using https://github.com/nomi9995/react-native-decompiler. The other main react native ofuscator plugin on the other hand didn't do anything. This one works if you add a
@whoami-shubham thanks for the plugin, it saved my day! The only issue I have now is it doesn't support json files, if I paste the same json files on the online editor here https://obfuscator.io/ it obfuscates it just fine so I know the underlying lib supports it. Would be great if this wrapper could pass those json files through as well! |
Hi @TowhidKashem can you try this exact version |
for json, try to use a library I build togather with this one node.data.obfuscator |
I've the same issue, I'm trying to use it with an ejected expo project (bare workflow). @TowhidKashem I applied your config to
I found that the warning comes from here: https://github.com/whoami-shubham/obfuscator-io-metro-plugin/blob/master/lib/utils.js#L28 Anyone know what I'm doing wrong? Note: I verified the bundle created and, as expected, it's not obfuscated. |
@F170x any updates? I get warning: Obfuscation SKIPPED [Not a bundle command] as well |
@CostasCF no updates, I don't know how to use it with Expo |
I used proguard instead for Android, checked the bundle created and indeed it was working. However, I am going to try to use this tool again and update you if I find anything. |
@CostasCF any luck? |
Unfortunately not. It doesn't seem to be working with Expo at the moment. |
@whoami-shubham @AnzeBlaBla Any update on this? I have the same issue after updating to Expo 50. Building on EAS with bundleRelease I get Obfuscation SKIPPED [Not a bundle command] |
Even if it's possible in expo standalone apps to use metro.config.js, this plugin simply do nothing.
Any clue on how to debug it?
The text was updated successfully, but these errors were encountered: