Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagementClient.online should declare more checked exceptions #87

Open
Ladicek opened this issue Apr 25, 2016 · 3 comments
Open

ManagementClient.online should declare more checked exceptions #87

Ladicek opened this issue Apr 25, 2016 · 3 comments
Assignees
@Ladicek
Milestone
3.0.0

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Apr 25, 2016 •
edited
Loading

This is so that all exceptions from OnlineOptions.createModelControllerClient don't have to be wrapped in IllegalStateException. It is source-incompatible, so it has to be done in a major release.
@Ladicek Ladicek self-assigned this Apr 25, 2016
@Ladicek Ladicek added this to the 2.0.0 milestone Apr 25, 2016
@Ladicek
Copy link
Contributor Author

Ladicek commented May 16, 2016

It should probably declare throws Exception.

@Ladicek Ladicek mentioned this issue May 19, 2016
Merged
@Ladicek
Copy link
Contributor Author

Ladicek commented May 19, 2016

The newly created SSL options (see #105) are also affected.

@Ladicek
Copy link
Contributor Author

Ladicek commented Jun 30, 2016

There's also OnlineManagementClientImpl.apply that catches InterruptedException and throws a different one. This needs careful examination, if the interruption status could possibly be lost in AutomaticErrorHandlingForCommands.

olukas pushed a commit to olukas/creaper that referenced this issue May 3, 2017
Merge pull request wildfly-extras#87 from hsvabek/my_elytron
823f710 
WFLY-8151 unignore TestCase
@simkam simkam modified the milestones: 2.0.0, 3.0.0 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ladicek Ladicek

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@Ladicek @simkam