Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show date of entry in each row #14

Open
willhains opened this issue Jun 5, 2016 · 5 comments
Open

Show date of entry in each row #14

willhains opened this issue Jun 5, 2016 · 5 comments
Assignees
@willhains
Labels
enhancement
Milestone
3.0

Comments

@willhains
Copy link
Owner

No description provided.

@GaborTheFisher
Copy link
Contributor

GaborTheFisher commented Jun 23, 2018 •
edited
Loading

I can take care of that.
Would like to propose to use CoreData for persistence insted of NSUserDefaults.

fweez added a commit to fweez/Kotoba that referenced this issue Jun 30, 2018
@fweez
Word list sorting feature
a25da77 
* Adds time-added attribute to Word objects, then deals with the fallout of that change
* New toolbar with a button to toggle between alphabetical & chronological sorting
* Display time (just the day, with fuzzy "yesterday" styling) on the word cells

This should satisfy github issues willhains#13 and willhains#14
fweez added a commit to fweez/Kotoba that referenced this issue Jun 30, 2018
@fweez
Word list sorting feature
91b898e 
* Adds time-added attribute to Word objects, then deals with the fallout of that change
* New toolbar with a button to toggle between alphabetical & chronological sorting
* Display time (just the day, with fuzzy "yesterday" styling) on the word cells

This should satisfy github issues willhains#13 and willhains#14
@willhains
Copy link
Owner Author

@GaborTheFisher Yes the current use of NSUserDefaults is a bit of an embarrassment. I did that as a quick temp solution and never got around to fixing it. Opened #34 for that — #29 and #14 (this issue) would I guess depend on it.

@GaborTheFisher
Copy link
Contributor

@willhains, just got back from holiday, so will have time look into this. Will most likely be using CoreData for this.

@willhains
Copy link
Owner Author

Sounds good. Hope you had a nice holiday! :)

@GaborTheFisher
Copy link
Contributor

Just a quick update on this and #34.
Have added the CoreData stack to the project and a way of migrating entried from NSUserDefaults.
I'm able to display existing entries using CoreData and a subclass of NSManagedObject.
Should be able to raise PR in the next couple of days.

@willhains willhains mentioned this issue Nov 19, 2019
Open
@willhains willhains self-assigned this Nov 19, 2019
@willhains willhains added this to the 2.0 milestone Nov 19, 2019
willhains pushed a commit that referenced this issue Nov 29, 2019
TODO for issue #14.
f40e4f7
willhains pushed a commit that referenced this issue Dec 1, 2019
Another TODO for #14.
85e7e8a
@willhains willhains modified the milestones: 2.0, 3.0 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willhains willhains

Labels
enhancement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@willhains @GaborTheFisher