Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong with the dates #33

Open
tiagosoares94 opened this issue Mar 8, 2024 · 2 comments
Open

Something is wrong with the dates #33

tiagosoares94 opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tiagosoares94
Copy link

Hello!
I've loved your project. nba.com/games is so bad.

About the error:

When you access the homepage, it shows the previous day's games, but with today's date.

To see today's games, you have to change the date, and then return to it via the calendar.

@mvfsillva
Copy link
Collaborator

Hey @tiagosoares94 I'm glad you're enjoying the project!

I attempted to replicate the error but couldn't encounter the issue.

Here are the steps I followed:

  1. Opened the homepage and checked the games.
  2. Clicked on the right arrow to proceed to the next day.
  3. Checked the games again.
  4. Clicked on the left arrow to return to "today."
  5. Checked the games once more.

Browser:

  • Chrome version 122.0.6261.94
  • Safari version 17.3.1
  • iOS Safari version 17

Could you please share which browser and version you are using?
Also, if possible, could you provide the steps to reproduce the issue?

Thanks

@mvfsillva mvfsillva self-assigned this Mar 13, 2024
@willianjusten
Copy link
Owner

I've seen this error already. Actually it happens during the mornings.

What happens is that the API that we get the today values updates during the day, so until they update to the next day, it displays the data from the previous day.

I was going to analyze more about this, but life got in the way...

I'll try to analyze this weekend to fix, probably it's just matter of updating the getDays function to get the day with a timezone or minus some hours (to be the same as the API).

If you go to the official site during the morning (Brazilian time) you'll see it displaying the games from a day before too. If we just mimick that, would be fine.

https://www.nba.com/games

@willianjusten willianjusten added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants