Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On node hover make text have a filled background Expander.coffee Line 50 #138

Open
davidfurlong opened this issue Feb 26, 2014 · 5 comments
Labels

Comments

@davidfurlong
Copy link
Collaborator

No description provided.

@willzeng
Copy link
Owner

willzeng commented Mar 2, 2014

This is a bit complicated by there not being a background color attribute for the svg text element. Perhaps we'll need to create a rectangle behind all the text elements that appears and disappears?

i.e. here

@backens
Copy link
Collaborator

backens commented Mar 2, 2014

Is this issue referring to the node text or to toplink-instructions?

Line 50 in Expander.coffee is the latter. That is a span and thus has
the css-attribute background-color, which means the change should be
fairly straightforward. It might be good for toplink-instructions to
have an opaque background anyway to improve legibility.

On 02/03/14 20:19, Will Zeng wrote:

This is a bit complicated by there not being a background color attribute for the svg text element. Perhaps we'll need to create a rectangle behind all the text elements that appears and disappears?

i.e. here


Reply to this email directly or view it on GitHub:
#138 (comment)

@willzeng
Copy link
Owner

willzeng commented Mar 3, 2014

My bad, I misread this to refer to the node.text svg element. The change to toplink-instructions is easy.

@davidfurlong
Copy link
Collaborator Author

This is for node.text svg element

@davidfurlong
Copy link
Collaborator Author

The other (toplink) has already been given a 0.8 opacity white background on my branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants