Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser_specific_settings #1102

Open
maxik34 opened this issue Jan 3, 2025 · 3 comments
Open

browser_specific_settings #1102

maxik34 opened this issue Jan 3, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@maxik34
Copy link

maxik34 commented Jan 3, 2025

I've been working on an extension, and the error Unrecognized manifest key 'browser_specific_settings' that appears after every reload of the extension is annoying. Yes, this is not an error, but only a warning. But the user who will use the extension will see the Errors button. It will feel like the extension is broken.

I'm not suggesting implementing this key and adding some functionality to it, I'm suggesting just ignoring it so that this message does not appear anymore.

It's ridiculous to make two identical versions of an extension, the difference being that one manifest file will have this parameter (for working in Firefox), and the other will not.

@maxik34 maxik34 added the enhancement New feature or request label Jan 3, 2025
@Half-Modern
Copy link

Upstream Chromium issue.

@win32ss
Copy link
Owner

win32ss commented Jan 4, 2025

Yes, Chrome has never supported this key. So even Supermium were to ignore this dependency it wouldn't help anyone running this extension in other Chromium browsers.

@maxik34
Copy link
Author

maxik34 commented Jan 4, 2025

Yes, but let it be fixed at least here.
When I was working with the source code of Source SDK 2013, I found a small typo that slightly broke the functionality of one entity and it turned out that this typo had not been fixed in any of the Source games, so I decided to propose fixing this typo for P2CE and Mapbase, so that at least it was fixed there.
Google will most likely never fix this, but we can, even if only for this chromium project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants