Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uppercase classes should be valid #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lianghx-319
Copy link

Change

  • Make uppercase as validClassName

Why

Such class names will be filtered, but they are valid too.

<div class="Any-CSS-ClassName"></div>

@antfu
Copy link
Member

antfu commented Feb 13, 2022

I do not get what you are trying to achieve. Yes uppercase can be valid class names, but in Windi CSS all utils are lowercase and I didn't see how this helps

@lianghx-319
Copy link
Author

For custom plugin, always lowercase limits how people implement there business usage. For me, I create a plugin generate T1-E-B component because the class name is defined in figma, there is no trade off to make it lowercase, and lowercase regexp filters my classNames. Eventually those classNames cannot passed to windicss processor.

@lianghx-319
Copy link
Author

Another reason: windicss core doesn't ignore uppercase classNames, such lowercase limitations make different behavior between windicss ordinary usage and webpack-plugin uasge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants