Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: enable unstable Temporal API in Deno #5226

Open
martinrlilja opened this issue Feb 6, 2025 · 0 comments
Open

feature: enable unstable Temporal API in Deno #5226

martinrlilja opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@martinrlilja
Copy link

martinrlilja commented Feb 6, 2025

Hello,

I would like to use the new Temporal API in Deno.

https://docs.deno.com/api/web/~/Temporal
https://developer.mozilla.org/en-US/blog/javascript-temporal-is-coming/

However it is gated behind the flag --unstable-temporal. I saw that I can add the flag to DENO_FLAGS but doing so disables many other flags required for deno to execute on the workers.

https://github.com/windmill-labs/windmill/blob/v1.457.0/backend/windmill-worker/src/deno_executor.rs#L381-L395

Maybe --unstable-temporal could be added as a default deno flag together with the others?

Another alternative to DENO_FLAGS would also be nice. One that doesn't disable any of the default flags.

Edit: Reading the code again I noticed that since we don't use NSJAIL we only have to add -A giving us DENO_FLAGS="--unstable-temporal --allow-all". Without it we got the error NotCapable: Requires read access to "args.json".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants