Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] ERC-165 checks in Bond contract for Treasury address #13

Open
CjHare opened this issue Oct 22, 2021 · 1 comment
Open

[Feature] ERC-165 checks in Bond contract for Treasury address #13

CjHare opened this issue Oct 22, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone
Bond v2

Comments

@CjHare
Copy link
Contributor

CjHare commented Oct 22, 2021 •
edited
Loading

Feature Description

Restrict the Treasury address (that receives bond slashing funds) to be able to receive ERC20 tokens.

Additional Information

This means the Treasury used needs to implement ERC165 and the check is made in the bond contract
@CjHare CjHare added the enhancement New feature or request label Oct 22, 2021
@CjHare CjHare self-assigned this Oct 22, 2021
@CjHare CjHare mentioned this issue Oct 25, 2021
Merged
@CjHare CjHare removed their assignment Dec 6, 2021
@CjHare
Copy link
Contributor Author

CjHare commented Jun 21, 2022

The problem with ERC-165 is it assumes you're asking honest contract, as there's nothing to prevent a contract saying it supports a function interface when it does not (lying).

Not sure whether it's worthwhile implementing,

@CjHare CjHare added this to the Bond v2 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bond v2
Development

No branches or pull requests
1 participant
@CjHare