Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Consider calling _setDaoMetadata() in createDao() #359

Open
aodhgan opened this issue Jul 15, 2022 · 3 comments
Open

[Feature] Consider calling _setDaoMetadata() in createDao() #359

aodhgan opened this issue Jul 15, 2022 · 3 comments
Assignees
@aodhgan
Labels
enhancement New feature or request

Comments

@aodhgan
Copy link
Contributor

aodhgan commented Jul 15, 2022

Feature Description

Suggested by @octavioamu to save gas

Additional Information
@aodhgan aodhgan added the enhancement New feature or request label Jul 15, 2022
@CjHare
Copy link
Contributor

CjHare commented Jul 17, 2022

suggestion: need more context.

What is currently being done?
How does this change save gas?

@jio-gl jio-gl self-assigned this Jul 18, 2022
@octavioamu
Copy link

Basically the suggestion is to do it the same way is done in Bonds. As this was a missed part of the implementation, the method to setDaoMetadata was added but is not part of the createDAO for example to be able to createDAO(address, Metadata) paying gas once instead of
CreateDao(address) (wait to finish)
setDaoMetadata(metadata).
Paying gas twice

@CjHare
Copy link
Contributor

CjHare commented Jul 18, 2022 •
edited
Loading

Gotcha, it to align it with Bonds 👍

@aodhgan aodhgan mentioned this issue Sep 22, 2022
Closed
@aodhgan aodhgan assigned aodhgan and unassigned jio-gl Sep 22, 2022
@aodhgan aodhgan mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aodhgan aodhgan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@octavioamu @CjHare @jio-gl @aodhgan