Parameters altered for the RF simulation part #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all the parameters are required for the RF simulation part as the I/Q samples need not to transfer via MCHEM, the USRP and its timing advance could be omitted.
gabri94
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Hi @aswanthkc, thanks for the contrib. Please review the comments
| @@ -257,7 +257,6 @@ def run_ue(self): | |||
| '--band', '78', | |||
| '-C', f'{self.ssb_frequency}', | |||
| '--ue-txgain', '0', | |||
| '-A', f'{self.conf["timing_advance"]}', | |||
There was a problem hiding this comment.
This needs to be conditional w.r.t to self.arg.rfsim, otherwise it will break on Colosseum/MCHEM
| args += ['--rfsim'] | ||
| else: | ||
| executable = main_exe | ||
| args += [f'-A {self.conf["timing_advance"]}'] |
There was a problem hiding this comment.
Ok, i see the logic, but I would keep al the config vars together above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all the parameters are required for the RF simulation part as the I/Q samples need not to transfer via MCHEM, the USRP and its timing advance could be omitted.