Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch job autotest #6

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Batch job autotest #6

wants to merge 50 commits into from

Conversation

leonardobonati
Copy link
Member

Created branch for PR to leave the testing one as is while we merge.

Copy link
Member Author

@leonardobonati leonardobonati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the PR, @saki92 can you help to check the changes in the conf.json file and base.conf [file](oai-confs/base.conf]? We might want to have a base.conf for the batch jobs as I see changes to the interfface addresses. Thank you.

I can test this branch before merging once we converge to a single version.

@leonardobonati leonardobonati changed the title Batch job autotest PR Batch job autotest Oct 14, 2024
Copy link
Collaborator

@gabri94 gabri94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave this as a radio.conf.example and put radio.conf in gitignore, so that we force whoever clones the repo to modify it andcopy it into radio.conf in this way we avoid committing changes to the .example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified

requirements.txt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants