Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a proper benchmark #70

Open
mbomb007 opened this issue Jan 24, 2025 · 1 comment
Open

Use a proper benchmark #70

mbomb007 opened this issue Jan 24, 2025 · 1 comment

Comments

@mbomb007
Copy link

mbomb007 commented Jan 24, 2025

"6 function calls in 0.000 seconds"? That's not a benchmark. You should call everything being benchmarked like 10,000 or 100,000 times so that the numbers are significant. Call each library/function the same number of times, and compare the runtime.

@winstxnhdw
Copy link
Owner

winstxnhdw commented Jan 24, 2025

Hey, I understand your concern. I initially wrote this benchmark to show the performance difference between the two libraries. I am not sure how useful would it be to measure KeyWin that many times as it would just be a measurement of how fast your OS can perform a system call. If you still think this would be a useful metric, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants