fix: camera on/off button when in fullscreen [WPB-9815] #3121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When a user double taps to expand (open in fullscreen) any participant's video, the button to toggle camera is not doing anything so if the user has camera enabled, then opens fullscreen and clicks on a camera button to turn it off, the button indicates that the camera is now off for the user but the app continues streaming video to other participants.
Causes (Optional)
Calls to start or stop sending video feed were associated with setting or clearing self video preview but only for the participants grid, not the fullscreen mode.
Solutions
Make start or stop sending video actions to be associated with
isCameraOn
state changes, independently from setting or clearing the video preview view - the user may not have the preview view present (because other participant's video is expanded to fullscreen) but still stream the video and be able to change camera state by clicking on a button.Testing
How to Test
Expected Result: The camera should turn off for both the user and other participants, stopping the video stream.
Actual Result: For the user, the video appears to be off, but other participants can still see the video stream.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.