-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve mention while typing (WPB-1895) #3690
Conversation
…f-not-supported-by-backend
…feature-if-not-supported-by-backend' into hide-personal-to-team-migration-feature-if-not-supported-by-backend
…eam-migration-feature-if-not-supported-by-backend
…eam-migration-feature-if-not-supported-by-backend
…f-not-supported-by-backend
…f-not-supported-by-backend
…feature-if-not-supported-by-backend' into hide-personal-to-team-migration-feature-if-not-supported-by-backend
# Conflicts: # app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModel.kt # app/src/test/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModelArrangement.kt # app/src/test/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModelTest.kt
@ohassine looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3690 +/- ##
===========================================
+ Coverage 45.75% 45.77% +0.01%
===========================================
Files 472 472
Lines 16020 16024 +4
Branches 2704 2705 +1
===========================================
+ Hits 7330 7335 +5
+ Misses 7929 7928 -1
Partials 761 761
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3690.apk is available for download |
Built wire-android-dev-debug-pr-3690.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Solutions
Redo the feature by covering all cases
mentions-android.mp4
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.