Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve mention while typing (WPB-1895) #3690

Merged
merged 27 commits into from
Dec 2, 2024
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Dec 2, 2024

StoryWPB-1895 [Android] Highlight mentions in TextInputs when typing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • The cursor does not stay in the correct position after ew remove or add some text having a mention.
  • Using Microsoft keyboard, it's not possible to type.

Solutions

Redo the feature by covering all cases

mentions-android.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…feature-if-not-supported-by-backend' into hide-personal-to-team-migration-feature-if-not-supported-by-backend
…eam-migration-feature-if-not-supported-by-backend
…eam-migration-feature-if-not-supported-by-backend
…feature-if-not-supported-by-backend' into hide-personal-to-team-migration-feature-if-not-supported-by-backend
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 2, 2024
# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModel.kt
#	app/src/test/kotlin/com/wire/android/ui/userprofile/self/SelfUserProfileViewModelArrangement.kt
#	app/src/test/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationViewModelTest.kt
Copy link
Contributor

github-actions bot commented Dec 2, 2024

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
4c476f7390ed6a7ffe27bc9ad0ce649c532ac35b 786a7b83e84663909c6c40b3f6c72263fe935661

Is this intentional?

@ohassine ohassine requested review from a team and yamilmedina and removed request for a team December 2, 2024 09:07
Copy link

sonarqubecloud bot commented Dec 2, 2024

@ohassine ohassine enabled auto-merge December 2, 2024 11:37
@ohassine ohassine added this pull request to the merge queue Dec 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 45.77%. Comparing base (e399e5b) to head (ac8f978).

Files with missing lines Patch % Lines
.../messagecomposer/state/MessageCompositionHolder.kt 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3690      +/-   ##
===========================================
+ Coverage    45.75%   45.77%   +0.01%     
===========================================
  Files          472      472              
  Lines        16020    16024       +4     
  Branches      2704     2705       +1     
===========================================
+ Hits          7330     7335       +5     
+ Misses        7929     7928       -1     
  Partials       761      761              
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 28.40% <0.00%> (-0.69%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e399e5b...ac8f978. Read the comment docs.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Built wire-android-staging-compat-pr-3690.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Built wire-android-dev-debug-pr-3690.apk is available for download

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 2, 2024
@ohassine ohassine added this pull request to the merge queue Dec 2, 2024
Merged via the queue into develop with commit d5b89ca Dec 2, 2024
12 of 13 checks passed
@ohassine ohassine deleted the mention-while-typing branch December 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants