Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the noData argument when having empty request/reponse models #259

Open
AlexITC opened this issue May 9, 2022 · 0 comments
Open

Remove the noData argument when having empty request/reponse models #259

AlexITC opened this issue May 9, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@AlexITC
Copy link
Contributor

AlexITC commented May 9, 2022

play-json doesn't generate codecs by default for empty case classes (or case object), we have replaced those with a case class having a single argument called noData, like case class Response(noData: String = ""). Let's remove such trick and use empty classes (or case object) instead.
@AlexITC AlexITC added the good first issue Good for newcomers label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexITC