-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala steward is not updating due to build errors #298
Scala steward is not updating due to build errors #298
Comments
Oh, that explains the lack of PRs (last one being #268), do you have any more logs? the ones attached are just info/warn. We have a CI workflow that compiles the app which is working https://github.com/wiringbits/scala-webapp-template/blob/master/.github/workflows/pull_request.yml Thanks for the report. |
Ach right! I had build failing with that message so I didn't check futher. The problem seems that it tries to run yarn:
We could try to add it to the image, though I wonder if it will be needed by Scala steward at all? Also, did it ever work previously? We seem to be using the same exact image as previously. |
Makes sense,
I bet this project isn't the only one depending on
Yes! #268 being a proof. |
I meant the Scala Steward updates, when did they stop showing up? |
Looks like maybe that was with the previous instance of Scala Steward, though not sure how does that happen if we were using the same image 🤔 Will need to check that. Not sure when I will be able to fix it, but you can set up a local Scala steward using github actions if needed. |
Sure, I already host such a workflow for our private repositories, one of those projects was created from this template and it is still receiving updates, it uses |
Seems like we need to add yarn in https://github.com/scala-steward-org/scala-steward/blob/main/build.sbt#L322-L353 If anyone has a bit of time to do that it would be awesome, otherwise I will try to go back to it at some point. |
Hmm, I don't see |
These tools are required to deal with some scala.js projects. See wiringbits/scala-webapp-template#298
@tgodzik I have raised a PR to include node/yarn on the docker image (scala-steward-org/scala-steward#2851), the image builds fine but I haven't had a chance to test whether that will solve the issue while finding updates for this project. |
Thanks! I think this should get picked up during the next run of Scala Steward. Let me know if you don't get any updates by the next week. |
@tgodzik looks like my PR did not fixed the problem, a project with similar structure has received a PR (wiringbits/wiringbits-webapp-utils#150). |
Weirdly enough I can't find anything in the logs now :/ I will try to run it again. |
Hi, I just looked at some logs from the Scala Steward repo and it seems currently the job is failing for this repository and not sending updates:
The text was updated successfully, but these errors were encountered: