fix: keep data store outside of node_modules during dev #11902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe58c9d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ascorbic
changed the title
bluwy
reviewed
Sep 3, 2024
bluwy
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently the data store file is written to the cache dir, which by default is in
node_modules/.astro. This causes a problem during dev on Windows and Linux, because chokidar ignores the whole node_modules folder, meaning changes are not picked up. Currently we add a negative match for the data store to the watcher ignores list, which works on Mac, but on other platforms only works if the file exists when the dev server starts. This seems to be a bug in chokidar.This PR changes the default data store path. During astro build it continues to use the cache dir, so that the store is preserved between builds in CI. However during dev it writes to the
.astrodir instead, meaning it is watched correctly on all platforms.Fixes PLT-2495
Testing
The tests on #11878 were failing, and this fixes them. There isn't currently another dev test that catches it. It can be tested on Windows and Linux by running
pnpm astro dev --forceinpackages/astro/test/fixtures/content-layer.Docs