fix(routing): actions should redirect the original pathname #12173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d1fc9c2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Oct 9, 2024
bluwy
approved these changes
Oct 10, 2024
|
Didn't notice the tests are failing 🙈 Could be related to copying the request |
Most probably, yeah. I think it's fine to not try to copy the body, and copy the request normally. Let's see if that works |
ematipico
force-pushed
the
fix/rewrites-and-actions
branch
from
b2e16a5 to
6b1d0e8
Compare
bluwy
approved these changes
Oct 11, 2024
Co-authored-by: Bjorn Lu <[email protected]>
Merged
Closed
1 task
Merged
ematipico
added a commit
that referenced
this pull request
Oct 15, 2024
* fix(routing): actions should redirect the original pathname * decode header to avoid index out of bounds * fix e2e test * Update packages/astro/e2e/actions-blog.test.js Co-authored-by: Bjorn Lu <[email protected]> --------- Co-authored-by: Bjorn Lu <[email protected]>
ematipico
added a commit
that referenced
this pull request
Oct 18, 2024
…12235) Co-authored-by: Bjorn Lu <[email protected]>
|
Looks like I have similar crash in production: astro: 4.16.7 |
|
Downgrade to 4.16.6 fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #12146
Closes PLT-2576
An Astro action uses
context.url.pathnamefor its redirect, however this is a bug because when there's a rewrite, theAPIContextgets updated in place when using `next(/payload/). Astro actions need to redirect to the same original URL where the initial request started.To fix the bug, we inject a well known header when we create
RenderContext, so no matter how many rewrites happen, the original pathname is always there and the sameTesting
Created a new e2e test
Docs
N/A