Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically load zod-to-ts #12273

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: dynamically load zod-to-ts #12273

merged 1 commit into from
Oct 21, 2024

Conversation

ascorbic
Copy link
Contributor

Changes

Builds have been failing with sites that don't have TypeScript installed when using some package managers. This is because zod-to-ts has a peer dependency on typescript. This PR changes typegen to dynamically import zod-to-ts inside a try/catch block, and return any for types if it fails.

Fixes #12204

Testing

Docs

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 9036f63

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 21, 2024
@ascorbic ascorbic merged commit c2ee963 into main Oct 21, 2024
13 checks passed
@ascorbic ascorbic deleted the optional-zod-ts branch October 21, 2024 14:20
@astrobot-houston astrobot-houston mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New project without Typescript does not start
3 participants