Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migation to standard decorators #183

Open
trusktr opened this issue Oct 17, 2024 · 1 comment
Open

migation to standard decorators #183

trusktr opened this issue Oct 17, 2024 · 1 comment

Comments

@trusktr
Copy link

trusktr commented Oct 17, 2024

Hello, I'm wondering if you will migrate to stage 3 standard decorators, and if you have any thoughts of feedback on issues like this one:

discrepancy: we're allowed to get/set private fields, but not public fields, and public auto accessors are not fields.

In particular it would be great to receive feedback there as to whether the problem impedes your implementation, and whether the solution idea helps your use case (or if it has no effect on your specific use case what you think of the problem and solution idea in general).

@guyca
Copy link
Collaborator

guyca commented Oct 18, 2024

Hey @trusktr, nice to see you here! 👋
I actually started converting the project to Stage 3 decorators in #175. It's published to NPM under the next tag.

I'm sorry but I've never used accessors. I read the issue, indeed this sounds very confusing 🫤
Hope this unexpected behavior won't bite us in the future

I started migrating our projects at Wix to it but hit a wall. I'm struggling with a bug in Babel's 2023-08 implementation. Apparently decorating classes that have static fields is bugged. babel/babel#16373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants