From 3a1ac0b0ec8ae7b1acfeec8456a387a6c448d7d5 Mon Sep 17 00:00:00 2001 From: wkh237 Date: Wed, 23 Nov 2016 09:23:46 +0800 Subject: [PATCH 1/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 59824e8e7..aa2eb2574 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "scripts": { "start": "node node_modules/react-native/local-cli/cli.js start", "update-info": "sh scripts/contributors.sh", - "test": "sh ./scrips/test.sh" + "test": "sh ./scripts/test.sh" }, "devDependencies": { "body-parser": "^1.15.0", From 749ac208d4817f6591930b5ee8c71b1200ecffc0 Mon Sep 17 00:00:00 2001 From: wkh237 Date: Wed, 23 Nov 2016 18:10:39 +0800 Subject: [PATCH 2/6] Update ISSUE_TEMPLATE --- .github/ISSUE_TEMPLATE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE b/.github/ISSUE_TEMPLATE index 4e9b4ce4f..65d12bb4c 100644 --- a/.github/ISSUE_TEMPLATE +++ b/.github/ISSUE_TEMPLATE @@ -1,4 +1,5 @@ -Hi ! Thank you for reporting an issue, but we would like to remind you, we have a trouble shooting page in our wiki. You may want to take a look on that page or find issues tagged "trouble shooting" :p +Hi ! Thank you for reporting an issue, but we would like to remind you, we have a trouble shooting page in our wiki. +You may want to take a look on that page or find issues tagged "trouble shooting" :p * please provide the version of installed library and RN project. * a sample code snippet/repository is very helpful to spotting the problem. From 189d65023d7fdd305ac07eee283f0e7b75d146bb Mon Sep 17 00:00:00 2001 From: wkh237 Date: Thu, 24 Nov 2016 17:26:43 +0800 Subject: [PATCH 3/6] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4962c9b0d..ec84dafe2 100644 --- a/README.md +++ b/README.md @@ -4,9 +4,9 @@ A project committed to make file acess and data transfer easier, efficient for React Native developers. -> If you're going to use github repo as npm dependency please use the [archive repository](https://github.com/wkh237/react-native-fetch-blob-package/releases/tag/v0.9.6). +> If you're going to use github repo as npm dependency please visit the [archive repository](https://github.com/wkh237/react-native-fetch-blob-package/releases/tag/v0.9.6). -> If you're using this library as Firebase Storage solution, please upgrade to 0.9.6 since XMLHttpRequest polyfill has way better compatibility than previous versions. +> For Firebase Storage solution, please upgrade to 0.10.1-beta.1 for best compatibility. ## Features - Transfer data directly from/to storage without BASE64 bridging From 5b326c060d93fae1b341039003a76e9b2d65b1d9 Mon Sep 17 00:00:00 2001 From: wkh237 Date: Thu, 24 Nov 2016 17:27:36 +0800 Subject: [PATCH 4/6] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ec84dafe2..4ab80674b 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ A project committed to make file acess and data transfer easier, efficient for R - Native-to-native file manipulation API, reduce JS bridging performance loss - File stream support for dealing with large file - Blob, File, XMLHttpRequest polyfills that make browser-based library available in RN (experimental) -- JSON stream supported base on [Oboe.js@jimhigson](https://github.com/jimhigson/oboe.js/) +- JSON stream supported base on [Oboe.js](https://github.com/jimhigson/oboe.js/) @jimhigson ## TOC * [About](#user-content-about) From 0848d50c86c69781945d3c995385d7c87ab10d3d Mon Sep 17 00:00:00 2001 From: wkh237 Date: Thu, 1 Dec 2016 09:59:27 +0800 Subject: [PATCH 5/6] Update README.md --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4ab80674b..1762063db 100644 --- a/README.md +++ b/README.md @@ -608,10 +608,10 @@ When calling `readStream` method, you have to `open` the stream, and start to re ```js let data = '' RNFetchBlob.fs.readStream( - // encoding, should be one of `base64`, `utf8`, `ascii` - 'base64', // file path PATH_TO_THE_FILE, + // encoding, should be one of `base64`, `utf8`, `ascii` + 'base64', // (optional) buffer size, default to 4096 (4095 for BASE64 encoded data) // when reading file in BASE64 encoding, buffer size must be multiples of 3. 4095) From 4bfba6c94c12cb781148d772d6dc3468e3585db8 Mon Sep 17 00:00:00 2001 From: 960px Date: Tue, 6 Dec 2016 03:11:14 +0800 Subject: [PATCH 6/6] openDocument&previewDocument utf8 Supports file names in more languages --- src/ios/RNFetchBlob/RNFetchBlob.m | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ios/RNFetchBlob/RNFetchBlob.m b/src/ios/RNFetchBlob/RNFetchBlob.m index 26fe3c216..b435c1837 100644 --- a/src/ios/RNFetchBlob/RNFetchBlob.m +++ b/src/ios/RNFetchBlob/RNFetchBlob.m @@ -440,8 +440,9 @@ - (NSDictionary *)constantsToExport RCT_EXPORT_METHOD(previewDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject { - - NSURL * url = [[NSURL alloc] initWithString:uri]; + NSString * utf8uri = [uri stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; + NSURL * url = [[NSURL alloc] initWithString:utf8uri]; + // NSURL * url = [[NSURL alloc] initWithString:uri]; documentController = [UIDocumentInteractionController interactionControllerWithURL:url]; UIViewController *rootCtrl = [[[[UIApplication sharedApplication] delegate] window] rootViewController]; documentController.delegate = self; @@ -459,8 +460,9 @@ - (NSDictionary *)constantsToExport RCT_EXPORT_METHOD(openDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject { - - NSURL * url = [[NSURL alloc] initWithString:uri]; + NSString * utf8uri = [uri stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]; + NSURL * url = [[NSURL alloc] initWithString:utf8uri]; + // NSURL * url = [[NSURL alloc] initWithString:uri]; documentController = [UIDocumentInteractionController interactionControllerWithURL:url]; documentController.delegate = self;