Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to publish SharpFFTW on Nuget? #4

Open
PhilPJL opened this issue Jul 29, 2022 · 3 comments
Open

Any plans to publish SharpFFTW on Nuget? #4

PhilPJL opened this issue Jul 29, 2022 · 3 comments

Comments

@PhilPJL
Copy link

PhilPJL commented Jul 29, 2022

Nice work btw :)

@PhilPJL PhilPJL changed the title Any plans to publish the library on Nuget? Any plans to publish SharpFFTW on Nuget? Jul 29, 2022
@wo80
Copy link
Owner

wo80 commented Jul 31, 2022

Nice work btw :)

Thanks!

This project hasn't received a lot of attention, so I haven't thought about publishing a Nuget package. The package probably wouldn't need much maintenance, so if you need it, I can publish one.

@PhilPJL
Copy link
Author

PhilPJL commented Jul 31, 2022

No it's ok, if needed I can re-use your code.
From your benchmarks it looks like FFTW is 40x faster than Math.Net which if true would be amazing. Unfortunately my initial attempts to use FFTW in our code only results in possibly 2x faster.
These are the results I get after modifying your test harness to work with a non-ideal test waveform with noise and calling initialize before each FFT.
image
I think FFTW may be worth the effort but it will need some work to use optimally in a multi-threaded app compared to Math.Net.

@wo80
Copy link
Owner

wo80 commented Jul 31, 2022

In the benchmark I tried to measure only the FFT (the Math.NET test for example includes a data copy, which should be O(n) at most, but still might affect the test result). The tests as they are implemented do the memory allocation inside the Initialize method, so if you include the method in the benchmark, in worst case you are measuring the GC kicking in. Seeing complex FFTW on the last place is a bit surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants