Clang format problems

[fiesh]

Alas, clang-format goes rather wild when there are no semicolons present between function declarations, putting them in one line if no empty line is in between, and indenting them when there is.

As a workaround, we added the following macro that allows adding a ; after the signal macro:

#define WS_SIGNAL(...) W_MACRO_MSVC_EXPAND(WS_SIGNAL2(__VA_ARGS__, 0))
#define WS_SIGNAL2(NAME, ...)                                                        \
	W_SIGNAL2(NAME, __VA_ARGS__) struct W_MACRO_CONCAT(w_Dummy_##NAME, __LINE__) \
	{                                                                            \
	}

So now we can write void signal(bool yay) WS_SIGNAL(signal, yay);, and clang-format plays along nicely.

I suspect we might not be the only ones who run into this, so maybe there is a place for something like this in verdigris itself?

Maybe there is also a better solution than defining a dummy struct to allow adding the extra ;?

[rakhimov]

isn't this a duplicate of #12?

[fiesh]

Ah sorry, it is... I didn't see it.

[fiesh]

Well actually it isn't, I think. The solution from #12 to just append a semi colon leads to a warning in clang when -Wextra-semi is used. The solution above doesn't. (That was the reason for the macro all along, I just forgot...)

[mathstuf]

FWIW, in a project I work on, we just live with the -Wextra-semi warnings. Having clang-format Just Work is better than a warning about something (generally) pretty benign. And no, // clang-format off doesn't work; clang-format still seems to track indentation from the parts it doesn't actually change to know what to do after the corresponding // clang-format on.