Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use valid HTML tag attribute names #189

Open
darkv opened this issue May 16, 2012 · 6 comments
Open

Use valid HTML tag attribute names #189

darkv opened this issue May 16, 2012 · 6 comments

Comments

@darkv
Copy link
Member

darkv commented May 16, 2012

The used custom attribute names of some components should be changed to conform the HTML specification. As an example the AjaxUpdateContainer component creates an element with an attribute updateUrl that breaks the validity of the generated HTML.

Those attributes should all be prefixed with data- as described in http://dev.w3.org/html5/spec/global-attributes.html#embedding-custom-non-visible-data-with-the-data-attributes

@paulhoadley
Copy link
Contributor

Looks like #281 is dealing with this.

@amedeomantica
Copy link
Member

Yes, I fixed that

@paulhoadley
Copy link
Contributor

Johann, does #281 address all of your concerns, and if so, can you close this ticket?

@darkv
Copy link
Member Author

darkv commented Oct 17, 2012

I do not know if updateUrl is the only problematic attribute name used in Wonder. I just picked that one because it's the most apparent. I will have to check that in the next couple of weeks.

@amedeomantica
Copy link
Member

Yes, there are meny others then I'm going to fix, but the updateUrl was everywhere :-)

Amedeo

On 17/ott/2012, at 13:18, Johann Werner [email protected] wrote:

I do not know if updateUrl is the only problematic attribute name used in Wonder. I just picked that one because it's the most apparent. I will have to check that in the next couple of weeks.


Reply to this email directly or view it on GitHub.

@darkv
Copy link
Member Author

darkv commented Jan 15, 2014

Hi amedeomantica,

did you – or any other – find other HTML attributes that have to be fixed? Otherwise we should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants