Channel Callbacks #713
Merged
Channel Callbacks #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add the new Channel Open callback support APIs.
1. Add channel open callback APIs to support two client callback functions, Channel Open Conf and Fail.
1. Added callbacks for receiving a Channel EOF message and a Channel Close message. 2. Added accessors for the new callback's ctx parameters. 3. Add some missing comments on the channel open callbacks.
1. Add callback for the "shell" Channel Request message for the server. 2. Whitespace and braces changes. 3. Relabel the string for administratively prohibited channel opens. 4. Add some comment.
1. Add checks for the Channel EOF or Close callbacks to the Do functions for those messages, and call them.
1. Move the session types earlier in the ssh.h header. 2. Add functions wolfSSH_ChannelGetSessionType() and wolfSSH_ChannelGetSessionCommand() to requestion information about a session.
1. Add a callback hook for channel requests of the exec type.
1. In DoChannelRequest(), rearrange the test cases. Start with the requests that are always expected as possible, and make the optional ones follow.
1. Treat any non-zero response from any of the channel request callback functions as a rejection of the channel request. 2. If a channel request reply is wanted, return the failure message if the callback function had rejected the request.
JacobBarthelmeh
approved these changes
Jul 15, 2024
douzzer
approved these changes
Jul 16, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Channel Callbacks
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Channel Callbacks
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Channel Callbacks
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Channel Callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a set of callback function hooks for various steps in the creation of a channel. These include:
A channel request can be rejected by the request callbacks. Also added functions to query a channel's connection type and exec command.