Dependency graph cycle detection seems too eager, finding cycles where there are none #1385
Labels
bug
Something isn't working
needs-triage
applied to all new customer/user issues. Removed after triage occurs.
Description
Still fresh to the tooling, but this is something I encountered when trying to test-rebuild some things against a new glibc. Scenario: in a PR I was updating glibc and wanted to rebuild binutils (and others) against it in a single PR. Without an explicit
glibc-dev
dependency (only viabuild-base
), the local glibc was not used. After checking the dag graph code, I added an explicitglibc-dev
dep to the build environment. This resulted in a cycle being detected and erroring out:...which feels to me incorrect, caused by the checker being over-eager.
binutils
has aglibc-dev
dependency, which comes from theglibc
source, but the only package fromglibc
which has thebash
runtime dependency isposix-libc-utils
, which is not installed whenglibc-dev
is installed. It simply is part of theglibc
set of packages. I feel as if this should not be considered a cycle. Runtime dependencies should matter only for the packages that are installed as part of the chain.Open to discussion.
The text was updated successfully, but these errors were encountered: