Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Streamline the onboarding flow #2631

Merged

Conversation

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.3%. Comparing base (2c82458) to head (ffd0de5).
Report is 87 commits behind head on feature/2458-2459-2460-2509.

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing ⚠️
.../free-listings/setup-free-listings/form-content.js 0.0% 1 Missing and 1 partial ⚠️
...c/components/stepper/step-content-actions/index.js 33.3% 1 Missing and 1 partial ⚠️
...ponents/free-listings/setup-free-listings/index.js 50.0% 1 Missing ⚠️
.../src/components/paid-ads/asset-group/faqs-panel.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             feature/2458-2459-2460-2509   #2631     +/-   ##
===============================================================
+ Coverage                           64.9%   65.3%   +0.4%     
+ Complexity                          4596    4589      -7     
===============================================================
  Files                                793     792      -1     
  Lines                              24342   24254     -88     
  Branches                            1231    1233      +2     
===============================================================
+ Hits                               15790   15833     +43     
+ Misses                              8379    8247    -132     
- Partials                             173     174      +1     
Flag Coverage Δ
js-unit-tests 62.7% <28.0%> (-<0.1%) ⬇️
php-unit-tests 66.0% <100.0%> (+0.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...choose-audience-section/choose-audience-section.js 33.3% <ø> (+8.3%) ⬆️
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/paid-ads/ads-campaign.js 0.0% <ø> (ø)
js/src/components/paid-ads/faqs-panel.js 66.7% <100.0%> (ø)
...rc/components/stepper/step-content-footer/index.js 50.0% <100.0%> (+16.7%) ⬆️
js/src/components/vertical-gap-layout/index.js 100.0% <ø> (ø)
js/src/data/action-types.js 100.0% <ø> (ø)
js/src/data/actions.js 7.9% <ø> (ø)
js/src/data/reducer.js 83.5% <ø> (-0.3%) ⬇️
js/src/data/resolvers.js 7.6% <ø> (+0.2%) ⬆️
... and 9 more
---- 🚨 Try these New Features:

@joemcgill joemcgill self-assigned this Sep 30, 2024
@joemcgill joemcgill marked this pull request as ready for review October 25, 2024 19:51
@joemcgill joemcgill changed the title Feature/2458 streamline onboarding Feature: Streamline the onboarding flow Oct 25, 2024
@mikkamp
Copy link
Contributor

mikkamp commented Oct 29, 2024

Just wanted to clarify that the failing unit test has already been resolved in PR #2626

We can ignore that here (no need to merge the latest changes into this branch).

@eason9487 eason9487 changed the base branch from develop to feature/2458-2459-2460-2509 November 20, 2024 07:10
@eason9487 eason9487 merged commit 4c934e4 into feature/2458-2459-2460-2509 Nov 20, 2024
16 checks passed
@eason9487 eason9487 deleted the feature/2458-streamline-onboarding branch November 20, 2024 08:49
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding Improvements Overview
6 participants