Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] [Cash & Receipts] Handle error on send receipt failure after successful payment #14464

Closed
Tracked by #14459
iamgabrielma opened this issue Nov 20, 2024 · 2 comments · Fixed by #14651
Closed
Tracked by #14459
Labels
feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

No description provided.

@iamgabrielma iamgabrielma added feature: POS type: task An internally driven task. labels Nov 20, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@iamgabrielma iamgabrielma changed the title [Woo POS] [Cash & Receipts] Handle error on sending receipt after payment [Woo POS] [Cash & Receipts] Handle error on send receipt failure after successful payment Nov 20, 2024
@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented Dec 3, 2024

Some more context from review:

Probably not; we need to be really careful not to give the impression that the payent has failed, when actually only sending the receipt has.

Potentially this would be a good place for the view to handle the thrown errors somehow; then we can more easily display the error in-line with the receipt call that they relate to. This would probably need a specific view that can handle them, rather than the default button.

In the IPP version of this, the button turns into a spinner while it's sending, then a check mark when it's done. Equally, it could show the error and a retry button if it fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
2 participants