Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

서포터 선택 필터 기능 useEffect dependency 수정 #200

Merged
merged 3 commits into from
Aug 3, 2023
Merged

서포터 선택 필터 기능 useEffect dependency 수정 #200

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e676d46
fix: supporterId와 key값이 겹치는 오류 수정
gyeongza Aug 3, 2023
645985b
fix: 무한으로 useEffect가 호출되는 오류 수정
gyeongza Aug 3, 2023
d3b359d
Merge branch 'dev/FE' into feat/190
gyeongza Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/SupporterSelect/SupporterSelectItem/SupporterSelectItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const SupporterSelectItem = ({
<S.Company>{company}</S.Company>
<S.TechStackContainer>
{technicalTags.map((tag) => (
<TechLabel key={supporterId} tag={tag} />
<TechLabel key={tag} tag={tag} />
))}
</S.TechStackContainer>
<S.CompletedReviewContainer>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/SupporterSelect/SupporterSelectList/SupporterSelectList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const SupporterSelectList = ({ handleSelectButton, selectedTechField }: Props) =
});
if (backend) setFilteredSupporter(backend);
}
}, [filteredSupporter, supporterCardList]);
}, [supporterCardList, selectedTechField]);

const selectedSupporter = (selectedSupporter: SupporterCard) => {
handleSelectButton(selectedSupporter);
Expand Down