Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] EventQueryService 리팩터링 #857

Open
java-saeng opened this issue Nov 28, 2023 · 0 comments · May be fixed by #868
Open

[REFACTOR] EventQueryService 리팩터링 #857

java-saeng opened this issue Nov 28, 2023 · 0 comments · May be fixed by #868
Assignees
@java-saeng
Labels
Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경
Milestone
2024 상반기

Comments

@java-saeng
Copy link
Collaborator

📌 어떤 기능을 리팩터링 하나요?

EventQueryService 리팩터링

AS-IS

null 처리나 필터링 관련 로직 분리

TO-BE

가벼운 EventQueryService

예상 소요 시간

1주일
@java-saeng java-saeng added Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경 labels Nov 28, 2023
@java-saeng java-saeng self-assigned this Nov 28, 2023
@github-project-automation github-project-automation bot moved this to Backlog in 2023-emmsale Nov 28, 2023
java-saeng added a commit that referenced this issue Dec 4, 2023
@java-saeng
refactor : null 처리를 Specification에서 하도록 수정
724ebec 
#857
java-saeng added a commit that referenced this issue Dec 4, 2023
@java-saeng
refactor : 일급 컬렉션 도입
9b6f11a 
#857
@java-saeng java-saeng linked a pull request Dec 4, 2023 that will close this issue
Open
@amaran-th amaran-th added this to the 2024 상반기 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@java-saeng java-saeng

Labels
Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경
Projects
2023-emmsale
Status: Backlog
Milestone
2024 상반기
Development

Successfully merging a pull request may close this issue.

Refactor/#857 event query service 리팩터링 woowacourse-teams/2023-emmsale
2 participants
@java-saeng @amaran-th